chore(deps): resolve dependabot security alerts - #455
Conversation
Drop firebase-tools from root devDependencies: its subtree was the source of most advisories (hono, re2, tar, tmp, morgan, basic-ftp, uuid, qs, ip-address). It is not needed at build time -- the PR preview workflow pins its own firebaseToolsVersion, and docs-stable now invokes it explicitly via npx. Pin the remaining vulnerable transitive packages via pnpm.overrides, using pkg@range selectors where only one major line is affected so minimatch@10, brace-expansion@2 and esbuild@0.25 stay untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe stable documentation deployment now pins Firebase CLI version 15.22.3. ChangesDocs toolchain
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 75ca9f1): https://react-koobiq-next--prs-455-ily23cl5.web.app (expires Sun, 16 Aug 2026 07:34:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
Removes firebase-tools from the root devDependencies (to reduce Dependabot security alerts) and pins remaining vulnerable transitive dependencies via pnpm.overrides, while updating the stable-docs deploy workflow to install Firebase tooling via npx.
Changes:
- Drop
firebase-toolsfrom rootdevDependencies. - Add
pnpm.overridespins for remaining vulnerable transitive dependencies. - Update
docs-stableGitHub Actions workflow to invoke Firebase tooling vianpx.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removes firebase-tools from root devDependencies and adds pnpm.overrides pins for vulnerable transitive packages. |
| .github/workflows/docs-stable.yml | Switches stable docs deployment to run Firebase tooling via npx instead of relying on a repo dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/docs-stable.yml:
- Line 23: Update the stable hosting deployment step to use an exact
firebase-tools version declared in the workspace and reflected in
pnpm-lock.yaml, then replace the npx invocation with pnpm exec while preserving
the existing deploy arguments and token usage.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4e7758f1-53ce-4f93-b82b-a2974c5d3cdc
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
.github/workflows/docs-stable.ymlpackage.json
Drop firebase-tools from root devDependencies: its subtree was the source of most advisories (hono, re2, tar, tmp, morgan, basic-ftp, uuid, qs, ip-address). It is not needed at build time -- the PR preview workflow pins its own firebaseToolsVersion, and docs-stable now invokes it explicitly via npx.
Pin the remaining vulnerable transitive packages via pnpm.overrides, using pkg@range selectors where only one major line is affected so minimatch@10, brace-expansion@2 and esbuild@0.25 stay untouched.
Summary by CodeRabbit